fix(g2pw): avoid redundant download when model files already exist #4141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
Others
Describe
Currently,
G2PWOnnxConverterusesdownload_and_decompress()unconditionally to obtain the model path. This function checks for the presence of the downloaded.ziparchive to decide whether to skip downloading.However, some users often delete the
.zipfile after extraction to save disk space (since the archive is no longer needed once the model is extracted). In such cases, even though the actual ONNX model file (g2pW.onnx) exists and is fully usable, the system will re-download the entire.ziparchive on next run — although it won’t re-extract if the model directory is intact.Changes
get_g2pw_model_path()that directly checks for the existence of the essential model file:g2pW.onnx.download_and_decompress()if this file is missing.